Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Requeue validation removal #254

Closed

Conversation

scorpioborn
Copy link
Contributor

Description

There is a validation at the beginning of the processWager method of the orderbook module. This validation does not support scenarios of requeue and refreshing the queue for the next round of processing.

Removal of the validation allows the order book process to be able to use subtracted amount of current round liquidity and maxloss in the calulcations.

Also, This may lead to a more (unnecessary) execution process in the requeue happening.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • Process Wager validation

Test Cases

  • Orderbook settlement

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@scorpioborn scorpioborn requested a review from a team as a code owner September 18, 2023 10:41
@3eyedraga 3eyedraga closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants